]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
portalHelper: Reduce the connectivity check rate limit
authorMichael Catanzaro <mcatanzaro@redhat.com>
Sun, 27 Jul 2025 14:44:02 +0000 (16:44 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 13 Sep 2025 16:54:45 +0000 (18:54 +0200)
30 seconds is much too long for GNOME Shell to notice that full
connectivity has been achieved. The portal helper is expected to be
closed once connectivity is achieved.

Note this does NOT mean we unconditionally spam the connectivity check
server every 5 seconds. A connectivity check is still only scheduled
when an actual navigation occurs.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3813>
(cherry picked from commit 1c80a4f213faef5170c3af6720d1e6d623fc45ad)

js/portalHelper/main.js

index af49d51a40cba66241cba1abe85dbe3e9f070844..9d420138c74e31437ba420b41b80eef455afcc6a 100644 (file)
@@ -35,7 +35,7 @@ const HTTP_URI_FLAGS =
 
 const CONNECTIVITY_CHECK_HOST = 'nmcheck.gnome.org';
 const CONNECTIVITY_CHECK_URI = `http://${CONNECTIVITY_CHECK_HOST}`;
-const CONNECTIVITY_RECHECK_RATELIMIT_TIMEOUT = 30 * GLib.USEC_PER_SEC;
+const CONNECTIVITY_RECHECK_RATELIMIT_TIMEOUT = 5 * GLib.USEC_PER_SEC;
 
 const HelperDBusInterface = loadInterfaceXML('org.gnome.Shell.PortalHelper');